Skip to content

fix dwarf debuginfo being used in addition to CodeView on windows #99252

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix dwarf debuginfo being used in addition to CodeView on windows #99252

merged 1 commit into from
Jul 14, 2022

Conversation

lqd
Copy link
Member

@lqd lqd commented Jul 14, 2022

Tackles the debuginfo size increase regression on windows to unblock clippy -- introduced by the DWARF5 support in #98350 cc @pcwalton.

r? @eddyb
Fixes #99143

@lqd
fix dwarf debuginfo being used in addition to CodeView on windows
97510f2 
Fixes the debuginfo size increase regression introduced by the DWARF5 support.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2022
@eddyb
Copy link
Member

eddyb commented Jul 14, 2022

Prioritizing to unblock/unbreak clippy CI (as per #99143 (comment)).
(Also, cc-ing @rust-lang/wg-debugging on this, just in case #98350 and/or this PR cause more surprises)

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented Jul 14, 2022

📌 Commit 97510f2 has been approved by eddyb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2022
@bors
Copy link
Collaborator

bors commented Jul 14, 2022

⌛ Testing commit 97510f2 with merge c2f428d...

@bors
Copy link
Collaborator

bors commented Jul 14, 2022

☀️ Test successful - checks-actions
Approved by: eddyb
Pushing c2f428d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 14, 2022
@bors bors merged commit c2f428d into rust-lang:master Jul 14, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 14, 2022
@lqd lqd deleted the win-dwarf5 branch July 14, 2022 22:03
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c2f428d): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.7% 4.8% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.0% -2.0% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.4% 3.4% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@flip1995
Copy link
Member

Thanks for addressing this so quickly! ❤️

@matthiaskrgr matthiaskrgr mentioned this pull request Feb 6, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Big file size regression on Windows
7 participants
@lqd @eddyb @bors @rust-timer @flip1995 @rust-highfive @rustbot